The first round is finally over! I received some great feedback from several people on the RPCFN comments section. AkitaOnRails says “Worked right off the bat, correct results, but it was just too brute force for my taste.” Michael Kohl says “A bit too complicated and repetitive for my personal taste, but definitely not bad for a Python coder coming over to Ruby-land.” And ashbb says “Ran the code with Ruby 1.9.1 and got the output file well. It was converted correctly. With Ruby 1.8.6, need to treat the message – undefined method ‘each_char’” These are all helpful comments and a good starting point. Now I know that each_char was called something else (or didn’t exist) pre Ruby 1.8.6. The other comments are a helpful starting place to learn what to look for in other code. Look for elegance and DRY principles. I don’t think I know enough Ruby to be elegant quite yet, but hopefully there will be improvement in round two.
Looking at AkitaOnRail’s last post congratulating everyone, he summarizes what the common problems were and styles of coding. Overall what I took away from that post to use in the next challenge is
- Naming conventions
- Gists on GitHub
- Project folder structure
- Attempt “Ruby-like” code
So I’m going to need to look up Ruby naming conventions when the next challenge starts/I have more time. All I’ve seen in Ruby code is an excess of underscores and verbose names, but I’m sure there are cases to learn when to use what. Honestly, I thought the goal was to make it all be in one file and not have a project structure, but now that I know that is what they are looking for, that is what I will do. Hmm I’ll have to look into gem specs as well. I think that will answer my question about executable programs.
Taking a look at other solutions I can clearly see a good project structure. Keep class files in the lib/, the binaries in the bin/ and the tests in spec/. I also picked up some ruby syntax, the delimited input! There are a ton of functions I need to look up, they seem like pretty basic ones. I’m liking the general feel of the Ruby code I’m looking at. I’ve only had a chance to read through a couple of solutions and would like to read through more before attempting to comment on any ones that I particularly like.
Definitely looking forward to the next challenge! This is a fun way to learn Ruby. Thanks to all people who are reading/test/judging the code. It seems like a lot of work and you guys are doing a great job!